This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
CompatHelper: bump compat for "Reexport" to "1.0" #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Weird that the CI workflow didn't run. |
|
It isn't weird: actions don't trigger other actions by default, unless you give them access to private keys. This is rather frustrating. Closing/reopening the PR should work though |
|
Ah, duh, right. Would be easy to set up the keys. |
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
- Coverage 49.94% 47.35% -2.59%
==========================================
Files 32 32
Lines 2515 2365 -150
==========================================
- Hits 1256 1120 -136
+ Misses 1259 1245 -14
Continue to review full report at Codecov.
|
tknopp
deleted the
compathelper/new_version/2020-12-26-00-32-14-898-588244134
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Reexportpackage from0.2to0.2, 1.0.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.