This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Support Graphics 1.0 and test set_coordinates (+Documenter bounds) #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, as I figured, this is a regression compared to the pre-JLL days. The warning about "infinite surface size not supported" is new; this might or might not be related to the failure to set the transformation (https://www.cairographics.org/manual/cairo-Transformations.html). |
This was referenced Dec 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
+ Coverage 48.03% 48.91% +0.87%
==========================================
Files 31 31
Lines 2117 2116 -1
==========================================
+ Hits 1017 1035 +18
+ Misses 1100 1081 -19
Continue to review full report at Codecov.
|
timholy
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for JuliaGraphics/Graphics.jl#16. It's better if the
set_coordinatestest gets done here since this the top of the dependency hierarchy. I have a suspicion it will fail based on JuliaGizmos/GtkReactive.jl#91 (and that this is a regression), but we will see.