-
Notifications
You must be signed in to change notification settings - Fork 78
Usage of Gtk on windows needs a warning #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After the second time wasting quite a bit of time to debug why everything is suddenly sluggish, until I noticed that some unexpected third party library was loading in Gtk, I come to the conclusion that we really need this warning.
|
I think this should be fixed in #447, if I remember correctly by https://github.com/JuliaGraphics/Gtk.jl/pull/447/files#diff-8c2b506e7179e52e816713686d731068 in particular |
|
That'd be awesome! Not really a reason against merging this, I guess ;) |
|
Oh, bad news Btw...From all I can see, I'm using #447, so doesn't seem fixed... |
|
Yes, very much in favor of merging this, I've been bitten too many times by this! |
|
I'm fine with merging this. |
|
I am not so happy with the warning, but its the peoples choice who use windows. @jonathanBieler are you using Windows? Did the fix of @vtjnash really did not fix the issue? On OSX it did. The plan now is as follows:
|
|
Maybe merge Cairo jll pull request before the one for gtk? |
|
Thats what I said with the third point, no? |
|
I mean for 2/3 it does not really matter to much, what the order is. |
|
The "fix" is in the JLL branch, see this: The communication is within the binarybuilder channel of slack. This was done by Jameson and Elliot. |
|
note that I needed dropping this as it conflicted badly with the JLL branch that has priority. The function where this was integrated was not present in the JLL branch :-) |
After the second time wasting quite a bit of time to debug why everything is suddenly sluggish, until I noticed that some unexpected third party library was loading Gtk, I come to the conclusion that we really need this warning.