Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Change curr_module to __module__ (or @__MODULE__ when appropriate) #386

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

fcard
Copy link
Contributor

@fcard fcard commented Sep 13, 2018

Fixes #367. Sorta messy but I didn't want to change things around too much. Still needs a test. Maybe cm needs a better name?

@jonathanBieler
Copy link
Collaborator

Thanks, I'll test it tomorrow.

@tknopp
Copy link
Collaborator

tknopp commented Sep 14, 2018

@fcard: thanks a lot, this is much better than my curr_module hack and prevents the warning. I will merge this as is (since tests are passing) and maybe @jonathanBieler can test if this now is also working within an external module.

@tknopp tknopp merged commit 4190f44 into JuliaGraphics:master Sep 14, 2018
@jonathanBieler
Copy link
Collaborator

It works yes, thanks @fcard !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants