Skip to content

fixed for 0.4/Colors.jl - #20

Merged
timholy merged 2 commits into
JuliaGraphics:masterfrom
cormullion:swatch-time
Oct 13, 2015
Merged

timholy merged 2 commits into
JuliaGraphics:masterfrom
cormullion:swatch-time

Conversation

@cormullion

Copy link
Copy Markdown
Member

although the output SVG is a bit different (colors are in a slightly
different order from before), this particular file is only a
quick-reference/pretty handout, so the changes aren’t significant… :)

although the output SVG is a bit different (colors are in a slightly
different order from before), this particular file is only a
quick-reference/pretty handout, so the changes aren’t significant…
@cormullion

Copy link
Copy Markdown
Member Author

failure is due to #15 I think

@timholy

timholy commented Oct 12, 2015

Copy link
Copy Markdown
Member

Out of curiosity, what error did this fix?

@cormullion

Copy link
Copy Markdown
Member Author

@timholy Well for one thing I left #!/Applications/Julia-0.3.9.app... at the top of the file. (Bad habit I have... :)) Also I changed the color comparison code (hslx = convert(LUV, RGB(rx, gx, bx)) 😱). But the failure of the tests is due to the colormap issues in #15.

@timholy

timholy commented Oct 12, 2015

Copy link
Copy Markdown
Member

I guess what I meant is: what is the motivation for this PR? Was it a deprecation warning, an error message, an incorrect answer, or something else?

@cormullion

Copy link
Copy Markdown
Member Author

Your revision of Aug 22 changed Color to Colors, but then the file failed with the error:

ERROR: LoadError: UndefVarError: LUV not defined
 in compare_colors 

(after changing the shebang line). I thought I'd better fix it (and improve it while I was there).

@timholy

timholy commented Oct 13, 2015

Copy link
Copy Markdown
Member

OK, thanks!

timholy added a commit that referenced this pull request Oct 13, 2015
@timholy
timholy merged commit f85cb64 into JuliaGraphics:master Oct 13, 2015
@cormullion
cormullion deleted the swatch-time branch October 13, 2015 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants