Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Ref() instead of pointer() for output arguments #364

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

jwahlstrand
Copy link
Contributor

@jwahlstrand jwahlstrand commented Apr 18, 2024

I think Ref is the recommended way to use output arguments: https://docs.julialang.org/en/v1/base/c/#Base.pointer

Might be a fix for #363 Never mind, I was able to check this locally and it doesn't fix the issue. It's definitely related to the recent Cairo_jll upgrade.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (ba5afd5) to head (dc0158a).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   92.52%   92.02%   -0.51%     
==========================================
  Files           1        1              
  Lines         589      552      -37     
==========================================
- Hits          545      508      -37     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah ViralBShah merged commit 09f9ca5 into JuliaGraphics:master Aug 12, 2024
6 of 7 checks passed
@jwahlstrand jwahlstrand deleted the readonly branch August 12, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants