-
Notifications
You must be signed in to change notification settings - Fork 44
Relax input type constraint to enable eltype promotion. #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the contribution! I tried the tests on my local machine, and it thew the following error. Test Summary: | Pass Total
Util | 201 201
Core: Test Failed at /home/hyrodium/.julia/dev/Rotations/test/2d.jl:21
Expression: Angle2d((1, 0, 0, 1, 0))
Expected: DimensionMismatch
Thrown: ArgumentError
Stacktrace:
[1] macro expansion
@ ~/.julia/dev/Rotations/test/2d.jl:21 [inlined]
[2] macro expansion
@ ~/julia/julia-1.7.1/share/julia/stdlib/v1.7/Test/src/Test.jl:1283 [inlined]
[3] macro expansion
@ ~/.julia/dev/Rotations/test/2d.jl:11 [inlined]
[4] macro expansion
@ ~/julia/julia-1.7.1/share/julia/stdlib/v1.7/Test/src/Test.jl:1283 [inlined]
[5] top-level scope
@ ~/.julia/dev/Rotations/test/2d.jl:10
Test Summary: | Pass Fail Total
2d Rotations | 4864 1 4865
Core | 10 1 11
Unitful | 4 4
Identity rotation checks | 12 12
zero checks | 18 18
Testing inv() | 1000 1000
Testing norm() and normalize() | 600 600
Rotate Points | 202 202
Rotate Unitful Points | 606 606
Compose rotations | 800 800
Convert rotations | 200 200
Types and products | 12 12
RotMatrix{2} vs Angle2d | 400 400
Angle2d | 700 700
angle | 300 300
ERROR: LoadError: Some tests did not pass: 4864 passed, 1 failed, 0 errored, 0 broken.
in expression starting at /home/hyrodium/.julia/dev/Rotations/test/2d.jl:4
in expression starting at /home/hyrodium/.julia/dev/Rotations/test/runtests.jl:17
ERROR: Package Rotations errored during testingThis seems to be caused by StaticArrays throwing |
|
Oops, I forgot to swith back to |
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 88.45% 88.45%
=======================================
Files 16 16
Lines 1602 1602
=======================================
Hits 1417 1417
Misses 185 185
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
hyrodium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
After the last commit & push, the "approve and run" button has appeared.

Close #229.