-
Notifications
You must be signed in to change notification settings - Fork 5
Implement differential and jacobian for Bezier curve integrals
#92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I was just thinking: Could we rename |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…hIntegrals.jl into bezier-derivative
|
Didn't see you were making edits and just pushed a couple of commits. I have to step away but will check back in a bit to try to sort it out. |
|
Oh, I'm sorry. I didn't want to disturb your development 😬 |
|
No worries! I'm glad to have the help, just got distracted over in VS Code and was surprised to see help had arrived. |
|
I just added a |
This is a really good idea. I think part of the trouble I had conceptually with extending (partial) In my mind, then, we've got jacobian(geometry::Meshes.Geometry, ts) # finite-diff fallback
jacobian(curve::Meshes.BezierCurve, ts) # analytic solution from today's derivative
# etc (as implemented)and can interface them the same in all integral functions. |
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ls.jl into bezier-derivative
differential and jacobian for Bezier curve integrals
|
Pending this latest commit passing CI, this should be good to go. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 90.50% 99.25% +8.75%
==========================================
Files 16 17 +1
Lines 316 269 -47
==========================================
- Hits 286 267 -19
+ Misses 30 2 -28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @mikeingold!
Completed
derivativefunction intojacobiandifferentialinside Bezier curve integral methods@testitemsection forBezierCurvewith analytic solutionjacobianto the Documenter site API page