- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5
 
Add test with ExplicitImports.jl #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           By skimming through the the documentation of ExplicitImport.jl again, I saw there are some new tests compared to the last time I checked. I also added them.   | 
    
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files          16       16           
  Lines         316      316           
=======================================
  Hits          286      286           
  Misses         30       30           ☔ View full report in Codecov by Sentry.  | 
    
| 
           Wow. Is it normal that the Downgrade Action takes >30 minutes to complete? (not blocking, this appears to be the case on other recent PR's as well, just curious)  | 
    
          
 I was also a bit surprised. Seems like more recent package versions made some significant performance improvements (which is also nice to see).  | 
    
I used https://github.com/ericphanson/ExplicitImports.jl to determine, which symbols are needed and imported them explicitly, which is considered a good practice. I also added a test to ensure only explicit imports and also no stale imports.