Skip to content

Conversation

@JoshuaLampert
Copy link
Member

I used https://github.com/ericphanson/ExplicitImports.jl to determine, which symbols are needed and imported them explicitly, which is considered a good practice. I also added a test to ensure only explicit imports and also no stale imports.

@JoshuaLampert
Copy link
Member Author

JoshuaLampert commented Sep 25, 2024

By skimming through the the documentation of ExplicitImport.jl again, I saw there are some new tests compared to the last time I checked. I also added them. check_all_qualified_accesses_are_public fails, e.g., because BezierEvalMethod is not exported from Meshes.jl, but used here. That's why I skipped this test. But I think that's fine.

@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (fb671d8) to head (5b00b9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files          16       16           
  Lines         316      316           
=======================================
  Hits          286      286           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold
Copy link
Collaborator

mikeingold commented Sep 25, 2024

Wow. Is it normal that the Downgrade Action takes >30 minutes to complete? (not blocking, this appears to be the case on other recent PR's as well, just curious)

@mikeingold mikeingold merged commit d784136 into main Sep 25, 2024
15 checks passed
@mikeingold mikeingold deleted the explicitimports branch September 25, 2024 23:31
@JoshuaLampert
Copy link
Member Author

Wow. Is it normal that the Downgrade Action takes >30 minutes to complete?

I was also a bit surprised. Seems like more recent package versions made some significant performance improvements (which is also nice to see).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants