-
Notifications
You must be signed in to change notification settings - Fork 5
Add support for integrating Meshes.Domain
and PolyArea
#182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Interesting. The remaining errors with the |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Still debugging. One of the remaining issues ( Edit: got it. There was a holdover in the default rule selection for the |
I've run some tests locally to figure out why the
|
Based on a little more debugging, even in the longer |
Changes
integral(f, ::Domain)
method that partitions a domain usingMeshes.discretize
and then sums the integrals of these sub-geometries.lineintegral
) to accept anything<:Meshes.GeometryOrDomain
union type.I'm planning for this PR to close #27 and #169
TODO
specializations/PolyArea.jl
with methodsdiff_method=FiniteDifference()
is still validdiff_method
are being determined at the correct level. I.e. ifSimpleMesh
doesn't directly support Enzyme, but results in sub-geometries inheriting that lack of support. Maybe just pass through allargs...
.CartesianGrid
tests take 80+ minutes?Add tests for integrating over:
CartesianGrid
PolyArea
RegularGrid
SimpleMesh
StructuredGrid