-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of StaticArrays #169
Conversation
This doesn't seem like the correct long term solution if we can cache precompiles between modules in 1.8+. Xref discussion from a while back: #91 |
That's not helping, since StaticArrays emits much harder code to compile...So until we cache binary, this is a valid approach. Benchmarks indicating the utility of this PR are done with Julia already caching between modules. Since the new code is much less complicated it does indeed shave off around 1-3s. See: MakieOrg/Makie.jl#1701 |
This does share some time off
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions around StaticArraysCore.jl
import Random | ||
import Base: setindex | ||
|
||
abstract type StaticVector{N, T} end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have StaticArraysCore.jl, so this definition can be removed.
@@ -7,6 +7,7 @@ version = "0.4.2" | |||
EarCut_jll = "5ae413db-bbd1-5e63-b57d-d24a61df00f5" | |||
IterTools = "c8e1da08-722c-5040-9ed9-7db0dc04731e" | |||
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" | |||
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" | |||
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" | |
StaticArraysCore = "1e83bf80-4336-4d27-bf5d-d5a4f845583c" |
@@ -1,10 +1,12 @@ | |||
module GeometryBasics | |||
|
|||
using StaticArrays, Tables, StructArrays, IterTools, LinearAlgebra | |||
using Tables, StructArrays, IterTools, LinearAlgebra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using Tables, StructArrays, IterTools, LinearAlgebra | |
using StaticArraysCore, Tables, StructArrays, IterTools, LinearAlgebra |
I'm going to close this for now.
|
And some other type clean ups.