Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reverse for AbstractParametricCurve and other changes #195

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

DanielVandH
Copy link
Member

  • Implement reverse(::AbstractParametricCurve)
  • Fix LineSegment should return the endpoints at t=0/t=1 #194
  • Restructured the curve files so that each curve has its own file.
  • Fixed an issue with over-enrichment, sometimes leading to duplicate points, for LineSegment curves.
  • Fixed an issue with orientation markers sometimes being nearly identical by using uniquetol as intended.
  • For N > 32, replaced the recursive tuple handling functions with a direct, non-stable, method.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 98.88984% with 13 lines in your changes missing coverage. Please review.

Project coverage is 94.94%. Comparing base (91dfbe7) to head (79afd2f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...data_structures/mesh_refinement/curves/abstract.jl 98.91% 4 Missing ⚠️
...ta_structures/mesh_refinement/boundary_enricher.jl 50.00% 3 Missing ⚠️
...structures/mesh_refinement/curves/ellipticalarc.jl 97.24% 3 Missing ⚠️
...ructures/mesh_refinement/curves/piecewiselinear.jl 94.87% 2 Missing ⚠️
.../data_structures/mesh_refinement/curves/bspline.jl 99.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   95.01%   94.94%   -0.07%     
==========================================
  Files          95      101       +6     
  Lines       10147    10178      +31     
==========================================
+ Hits         9641     9664      +23     
- Misses        506      514       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVandH DanielVandH merged commit 455b592 into main Sep 30, 2024
6 of 8 checks passed
@DanielVandH DanielVandH deleted the reverse branch September 30, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LineSegment should return the endpoints at t=0/t=1
1 participant