Construct affine transforms from point-pairs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a set of point pairs `from => to`, compute the affine transformation that best reproduces the observed mapping. Closes #30
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 63.90% 66.54% +2.63%
==========================================
Files 4 4
Lines 266 275 +9
==========================================
+ Hits 170 183 +13
+ Misses 96 92 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c42f
approved these changes
May 2, 2023
src/affine.jl
Outdated
| If there are more points than this, the transformation will be over-determined and a least-squares | ||
| solution will be computed. | ||
| """ | ||
| function AffineMap(mappedpairs::AbstractVector{<:Pair}) |
There was a problem hiding this comment.
I wonder might this be better as AffineMap((from_points,to_points)::Pair) ?
That way there may be less unpacking and packing to do for typical use cases? For example, in the tests you'd have
A2 = AffineMap(from=>from)
without the need to construct and allocate mappedpairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a set of point pairs
from => to, compute the affinetransformation that best reproduces the observed mapping.
Closes #30