Implement crs and geometrycolumn fallbacks via DataAPI #161
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
asinghvi17
commented
Sep 21, 2024
•
asinghvi17
commented
- Needs tests
- needs docs
asinghvi17
commented
Sep 21, 2024
Comment on lines
+101
to
+108
| function _get_dataapi_metadata(geom::GeomType, key, default) where GeomType | ||
| if DataAPI.metadatasupport(GeomType).read | ||
| if key in DataAPI.metadatakeys(geom) | ||
| return DataAPI.metadata(geom, key; style = false) | ||
| end | ||
| end | ||
| return default | ||
| end |
There was a problem hiding this comment.
Should I move this to some other location / file?
There was a problem hiding this comment.
Maybe to (a new) metadata.jl? I discussed having a Geometadata.jl package with @rafaqz, but that's probably overkill for now.
13 tasks
|
This needs to also check the type of the returned geometrycolumns data, and if it's not a tuple of symbols (maybe it's a String, since Arrow only supports String -> String metadata), it should convert it. Does that make sense? |
|
You mean if its a single |
|
Yes |
|
Sounds pragmatic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.