**BREAKING** Type Stability for MOInputs #405
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make input collection types for isotopic multi-output things type stable.
Proposed changes
Change the
Integer
type constraint inMOInputIsotopicByFeatures
andMOInputIsotopicByOutputs
withInt
s.What alternatives have you considered?
Could have parametrised the type to allow any
Integer
, but I think this is probably fine.Breaking changes
If anyone is currently using anything other than an
Int
to specify the number of outputs, they'll need to change it to anInt
. I can't imagine that this happens very often, so effects should be minimal.