Skip to content

Run examples with separate processes #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 29, 2021
Merged

Run examples with separate processes #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cd068bf
Run examples with separate processes
devmotion Jun 28, 2021
c3956dc
Update CompatHelper
devmotion Jun 28, 2021
dbaa9b3
Fix SVM example
devmotion Jun 28, 2021
1b4e9fa
Fix GR error messages
devmotion Jun 28, 2021
5783d9f
Improve SVM example
devmotion Jun 28, 2021
efa6acf
Try to fix edit link
devmotion Jun 28, 2021
e5e4dfe
Fix preprocessing
devmotion Jun 28, 2021
f863314
Fix links
devmotion Jun 28, 2021
ce3037f
Move "SVM" example back to svm.jl
devmotion Jun 29, 2021
fca865c
Minor simplification
devmotion Jun 29, 2021
cdb955c
Update .github/workflows/docs.yml
devmotion Jun 29, 2021
abef80d
Fix test errors
devmotion Jun 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions .github/workflows/CompatHelper.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,33 @@
name: CompatHelper

on:
schedule:
- cron: '00 00 * * *'
- cron: 0 0 * * *
workflow_dispatch:

jobs:
CompatHelper:
runs-on: ubuntu-latest
steps:
- name: Pkg.add("CompatHelper")
run: julia -e 'using Pkg; Pkg.add("CompatHelper")'
- name: CompatHelper.main()
- name: "Install CompatHelper"
run: |
import Pkg
name = "CompatHelper"
uuid = "aa819f21-2bde-4658-8897-bab36330d9b7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to change to pinning CompatHelper? is there any reason not to want the latest version (with potential bugfixes etc)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UUID is just an additional guarantee that it is the correct package but does not fix the version. The version is only pinned to 2.x.x but no specific version, i.e., it has to be updated only if there is a breaking release of CompatHelper.

In general, this is just copied from the documentation of CompatHelper: https://juliaregistries.github.io/CompatHelper.jl/dev/

version = "2"
Pkg.add(; name, uuid, version)
shell: julia --color=yes {0}
- name: "Run CompatHelper"
run: |
import CompatHelper
subdirs = ["", "test", "docs"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the empty "" do here? If it's referring to the repo base directory, why would it need to be passed to _sub_dirs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the base directory is not updated anymore. The default setting is subdirs = [""]: https://juliaregistries.github.io/CompatHelper.jl/dev/options/#Packages-in-subdirectories

for f in readdir(joinpath(@__DIR__, "examples"); join=true)
if isdir(f)
push!(subdirs, joinpath("examples", basename(f)))
end
end
CompatHelper.main(; subdirs=subdirs)
shell: julia --color=yes {0}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }}
run: julia -e 'using CompatHelper; CompatHelper.main(; subdirs = ["", "docs", "test"])'
1 change: 1 addition & 0 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
run: julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'
- name: Build and deploy
env:
GKSwstype: nul # turn off GR's interactive plotting for notebooks
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # For authentication with GitHub Actions token
DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }} # For authentication with SSH deploy key
run: julia --project=docs/ docs/make.jl
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*.json
*.cov
Manifest.toml
/Manifest.toml
/test/Manifest.toml
coverage/
src/update_v0.8.0
.DS_store
3 changes: 1 addition & 2 deletions docs/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
build/
site/

#Temp to avoid to many changes
src/examples/
Loading