KI Sub-groups#668
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
6852410 to
84730d2
Compare
daea025 to
6343fd2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
+ Coverage 52.18% 52.24% +0.06%
==========================================
Files 22 22
Lines 1694 1736 +42
==========================================
+ Hits 884 907 +23
- Misses 810 829 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6343fd2 to
a86cc8c
Compare
a86cc8c to
6f4a517
Compare
f0a545c to
8858825
Compare
7ddba7e to
8de2c42
Compare
8de2c42 to
82d32db
Compare
409a1e7 to
08a8130
Compare
b1d526f to
2f02082
Compare
Co-Authored-By: Anton Smirnov <tonysmn97@gmail.com>
|
This is mostly ready except that for correctness of algorithms, I think it requires us to know the subgroup size of a device at compile time. I tried to force a known subgroup size for openCL/pocl, but that seems to have broken on-kernel rand. I'm not sure how to best approach this. I currently work around this in OpenCL.jl to test that the rest works by forcing a workgroup size in the KI launch interface so that the non-KI rand kernel doesn't encounter this issue, but that's a hack. I think the ideal solution would be to have |
Includes #682