This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Specialized _var and _std functions #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! These definitions seems OK, if they execute without scalar iteration of course. Could you add some tests comparing against results with Base.Array? |
|
I added some, please let me know if these need changes or need to be expanded. |
maleadt
suggested changes
Mar 13, 2020
|
I made the changes and also realized the tests hadn't actually been added to the runtests.jl so that's fixed as well 😅. |
maleadt
approved these changes
Mar 13, 2020
|
bors try |
tryBuild succeeded |
|
Great, let's merge this. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried writing a CuArrays version for _var and _std which fixes #411.
@kshyatt mentioned the issue actually lies in centralize_sumabs2! but I'm not quite sure what that function does or how it should be done on gpu.
Perhaps this solution suffices?