Skip to content
This repository was archived by the owner on May 27, 2021. It is now read-only.

Revert upstream SubArray bounds checking change #316

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Revert upstream SubArray bounds checking change #316

merged 2 commits into from
Jan 15, 2019

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 9, 2019

Fixes #313

@maleadt maleadt force-pushed the tb/subarray_boundserror branch from 1e081ca to 914ed3e Compare January 9, 2019 13:35
@maleadt
Copy link
Member Author

maleadt commented Jan 9, 2019

Remove the actual revert since it is addressed by JuliaLang/julia#30666. Keep the test.

@maleadt
Copy link
Member Author

maleadt commented Jan 10, 2019

Just to be sure, this should fail now on rc1, but will work on rc2.
bors try

bors bot added a commit that referenced this pull request Jan 10, 2019
@bors
Try #316:
45d9960
@bors
Copy link
Contributor

bors bot commented Jan 10, 2019

try

Build failed

@maleadt
Copy link
Member Author

maleadt commented Jan 15, 2019

JuliaGPU/gitlab-ci@7c06f60
bors r+

bors bot added a commit that referenced this pull request Jan 15, 2019
@bors @maleadt
Merge #316
7aba834 
316: Revert upstream SubArray bounds checking change r=maleadt a=maleadt

Fixes #313

Co-authored-by: Tim Besard <tim.besard@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 15, 2019

Build succeeded

@bors bors bot merged commit c1e67d3 into master Jan 15, 2019
@bors bors bot deleted the tb/subarray_boundserror branch January 15, 2019 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maleadt