Remove the unnecessary reshape during mapreduce.

[maleadt]

Fixes #2777

[github-actions]

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.

diff --git a/src/mapreduce.jl b/src/mapreduce.jl
index 5175a8060..24cb32317 100644
--- a/src/mapreduce.jl
+++ b/src/mapreduce.jl
@@ -226,7 +226,7 @@ function GPUArrays.mapreducedim!(f::F, op::OP, R::AnyCuArray{T},
     # we might not be able to launch all those threads to reduce each slice in one go.
     # that's why each threads also loops across their inputs, processing multiple values
     # so that we can span the entire reduction dimension using a single thread block.
-    kernel = @cuda launch=false partial_mapreduce_grid(f, op, init, Rreduce, Rother, Val(shuffle), R, A)
+    kernel = @cuda launch = false partial_mapreduce_grid(f, op, init, Rreduce, Rother, Val(shuffle), R, A)
     compute_shmem(threads) = shuffle ? 0 : threads*sizeof(T)
     kernel_config = launch_configuration(kernel.fun; shmem=compute_shmem∘compute_threads)
     reduce_threads = compute_threads(kernel_config.threads)
@@ -266,7 +266,7 @@ function GPUArrays.mapreducedim!(f::F, op::OP, R::AnyCuArray{T},
         @cuda(threads, blocks, shmem,
               partial_mapreduce_grid(f, op, init, Rreduce, Rother, Val(shuffle), partial, A))
 
-        GPUArrays.mapreducedim!(identity, op, R, partial; init=init)
+        GPUArrays.mapreducedim!(identity, op, R, partial; init = init)
     end
 
     return R

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (bb8259f) to head (beb7d91).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2778      +/-   ##
==========================================
- Coverage   89.71%   89.57%   -0.15%     
==========================================
  Files         153      153              
  Lines       13228    13227       -1     
==========================================
- Hits        11868    11848      -20     
- Misses       1360     1379      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kishore-nori]

Thank you very much again! Is it possible to do a release?

[maleadt]

We typically don't do immediate releases for bug fixes like this (except for hotfix releases, so feel free to create a PR for that). A release is not far off, though.

[kishore-nori]

Good to know, I can wait. Will use the master till then. Thank you!