Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Compat dependency + Update CI #44

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Drop Compat dependency + Update CI #44

merged 4 commits into from
Sep 18, 2024

Conversation

carstenbauer
Copy link
Member

IMO, it is not worth it just for the public keyword. We can use the recommendation from https://docs.julialang.org/en/v1.12-dev/manual/modules/#Export-lists instead.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (eb1e0a6) to head (594c06e).
Report is 7 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   94.00%   95.27%   +1.27%     
==========================================
  Files           2        2              
  Lines         250      233      -17     
==========================================
- Hits          235      222      -13     
+ Misses         15       11       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carstenbauer carstenbauer changed the title Drop Compat dependency Drop Compat dependency + Update CI Sep 18, 2024
@carstenbauer
Copy link
Member Author

I've updated the CI config to now test lts, the latest 1.x release, and pre.

@lmiq lmiq merged commit ee05827 into main Sep 18, 2024
22 checks passed
@lmiq lmiq deleted the cb/nocompat branch September 25, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants