Julia 1.0 update #15
Merged
Julia 1.0 update #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 93.31% 98.27% +4.96%
==========================================
Files 11 10 -1
Lines 598 348 -250
==========================================
- Hits 558 342 -216
+ Misses 40 6 -34
Continue to review full report at Codecov.
|
nantonel
commented
Sep 20, 2018
test/runtests.jl
Outdated
|
|
||
| @testset "ProximalAlgorithms" begin | ||
|
|
||
| @testset "Utilities" begin | ||
| include("test_block.jl") | ||
| include("test_block.jl") # remove? |
There was a problem hiding this comment.
not sure why we had these test, I believe they could be removed. @lostella don't you think?
There was a problem hiding this comment.
but all of the tests of test_block are already in AbstractOperators and these test do not cover any code of ProximalAlgorithms itself...
lostella
reviewed
Sep 20, 2018
src/REQUIRE
Outdated
| @@ -0,0 +1 @@ | |||
| FFTW 0.2.4 | |||
There was a problem hiding this comment.
whops, will remove!
test/runtests.jl
Outdated
|
|
||
| @testset "ProximalAlgorithms" begin | ||
|
|
||
| @testset "Utilities" begin | ||
| include("test_block.jl") | ||
| include("test_block.jl") # remove? |
This was referenced Sep 22, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #13 and #14.
There are many things that can be further fixed/changed following the blog post of @lostella and what is currently done in PANOC.jl.
But I would leave this for another PR.