-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia 1.0 update #15
Julia 1.0 update #15
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 93.31% 98.27% +4.96%
==========================================
Files 11 10 -1
Lines 598 348 -250
==========================================
- Hits 558 342 -216
+ Misses 40 6 -34
Continue to review full report at Codecov.
|
test/runtests.jl
Outdated
|
||
@testset "ProximalAlgorithms" begin | ||
|
||
@testset "Utilities" begin | ||
include("test_block.jl") | ||
include("test_block.jl") # remove? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why we had these test, I believe they could be removed. @lostella don't you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s leave it as it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but all of the tests of test_block
are already in AbstractOperators and these test do not cover any code of ProximalAlgorithms
itself...
src/REQUIRE
Outdated
@@ -0,0 +1 @@ | |||
FFTW 0.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whops, will remove!
test/runtests.jl
Outdated
|
||
@testset "ProximalAlgorithms" begin | ||
|
||
@testset "Utilities" begin | ||
include("test_block.jl") | ||
include("test_block.jl") # remove? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s leave it as it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash and merge B-)
Addressing #13 and #14.
There are many things that can be further fixed/changed following the blog post of @lostella and what is currently done in PANOC.jl.
But I would leave this for another PR.