-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Int64 type definition from Problem #115
base: master
Are you sure you want to change the base?
Conversation
Problem function defined dimension as an Int64 type, and this restricts using JuliaFEM on 32bit architecture. Changed type to a more generic: Integer. fixes issue JuliaFEM#113
We are also having problems with
In general, should we use |
it'd be more general if we would change. |
No. |
Oh, I misread this at first. Yes, you won't have performance issues if you loosen function definitions, so it's usually recommended you go to |
return Problem{P}(name, dimension, "none", [], Dict(), Assembly(), Dict(), Vector(), P()) | ||
end | ||
function Problem{P<:FieldProblem}(::Type{P}, dimension::Int64) | ||
function Problem{P<:FieldProblem, I<:Integer}(::Type{P}, dimension::I) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can make this dimension::Integer
to make it more succinct.
This particular file has been fixed in FEMBase, however, there's still use of Int64 in code, which should be replaced with Int. In order to make progress, we should activate Appvoyer to test in 32-bit environment to catch all problems with type definitions. See this PR (JuliaFEM/FEMBase.jl#46). |
Problem function defined dimension as an Int64 type, and this
restricts using JuliaFEM on 32bit architecture. Changed type to
a more generic: Integer.
fixes issue #113