Conversation
It's better to implement three different kind of DOFMaps. This is the first one and should be compatible with the curren definition. We can then later on extend to FixedDOFMap where we can effectively make a bandwidth-minimizing permutation ourself and later on VariableDOFMap so that each node can have different number of dofs.
Also, losen data type definitions in `add!` so that generators works also when adding data do sparse matricse.
ahojukka5
force-pushed
the
master
branch
2 times, most recently
from
a711587 to
bcb4840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the location of degrees of freedom in matrix level is implemented somewhat naive way, given maximum number of degrees of freedom
max_dim, node idj, and index of dofi, we havegdofs(j,i) = max_dim(j-1)+i. This works, but does not support variable number of degrees of freedom per node, which is mandatory if we want to couple structural elements with continuum elements or have, for instance, pressure degree of freedom in some nodes and in some nodes not. This PR implements new typeDOFMapwhich makes it easy to create more complex configurations of degrees of freedom.