-
Notifications
You must be signed in to change notification settings - Fork 20
Pure Julia WKT2 to PROJJSON conversion #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
00449b1
to
f4d782e
Compare
f4d782e
to
24b4323
Compare
@Omar-Elrefaei this looks promising. Please let me know when it is ready for review. |
Some deep issues with the design here:
My design is more complex in part because it tackles these issues and more. |
Thank you for sharing @nsajko. Appreciate your inputs. If you can evolve your PR to a final version to show the technical advantages in practice, we will happily consider it. Both PRs are still work in progress, but it is really nice to see the high quality of the attempts already. |
These end up effecting the "datum" json items
I think this is functionally mostly there, save for few rare edge cases. few of the concerns brought up by nsajko are justifies, some are design tradeoffs, and some are a non-issue, I think. I'll take time to elaborate soon. |
Working towards #150