Support for fixed points of n-th order in fixedpoints
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datseris
reviewed
Mar 17, 2024
src/stability/fixedpoints.jl
Outdated
Comment on lines
116
to
120
| for i in 2:o | ||
| trajectory[i] = ds.f(trajectory[i-1], p, 0.0) # trajectory from DynamicalSystemsBase won't work because of IntervalRootFinding | ||
| end | ||
| reverse!(trajectory) | ||
| jacobians = map(x -> Jf(x, p, 0.0), trajectory) |
There was a problem hiding this comment.
I am not sure I understand the necessity of this trajectory. Why make a trajectory container and loop over, instead of initializing a Jacobian matrix and multiplying in the loop? J *= Jf(x, p, 0) and x = ds.f(x, p, 0) would do the trick in the loop.
There was a problem hiding this comment.
Good idea. I simplified the function.
Datseris
reviewed
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 54.86% 56.05% +1.18%
==========================================
Files 22 22
Lines 904 917 +13
==========================================
+ Hits 496 514 +18
+ Misses 408 403 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for computing fixed points of n-th iteration of a discrete dynamical system.