Update HTMLWriter logo handling and arguments #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The logo could be used for the pdf output too though, e.g. #949 so maybe not move |
|
The |
mortenpi
force-pushed
the
mp/logo-formats
branch
from
778af51
to
709db50
Compare
fredrikekre
reviewed
Feb 11, 2019
Deprecates the analytics and assets keywords to makedocs in favour of the corresponding HTML() arguments. The reasoning is that those particular makedocs arguments are very HTMLWriter-specific.
mortenpi
force-pushed
the
mp/logo-formats
branch
from
1f1c967
to
5519188
Compare
fredrikekre
approved these changes
Feb 12, 2019
This was referenced Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two slightly related changes (as in I got carried away when I was trying to document the logo).
HTML()arguments. The reasoning is that those particular makedocs arguments are veryHTMLWriter-specific.Ref #212, close #308.