Don't use the Module(...) constructor to create a module

CHANGELOG.md

@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+* Added anchor links to admonition blocks, making it possible to create direct links to specific admonitions. ([#2505], [#2676])
+
+## Fixed
+
+* `@meta`, `@setup`, and `@docs` blocks no longer generate spurious entries in the search index. ([#1929], [#2675])
+* Modules for `@example` environments are now generated by `eval`'ing an expression, rather than invoking the `Module` constructor,
+  which is not recommended. (#2683)
 * Added anchor links to admonition blocks, making it possible to create direct links to specific admonitions. ([#2505], [#2676], [#2688])
 * Added different banners for dev and unreleased docs ([#2382], [#2682])
 
@@ -2025,6 +2032,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 [#2659]: https://github.com/JuliaDocs/Documenter.jl/issues/2659
 [#2662]: https://github.com/JuliaDocs/Documenter.jl/issues/2662
 [#2674]: https://github.com/JuliaDocs/Documenter.jl/issues/2674
+[#2683]: https://github.com/JuliaDocs/Documenter.jl/pull/2683
 [#2675]: https://github.com/JuliaDocs/Documenter.jl/issues/2675
 [#2676]: https://github.com/JuliaDocs/Documenter.jl/issues/2676
 [#2682]: https://github.com/JuliaDocs/Documenter.jl/issues/2682

src/utilities/utilities.jl

@@ -618,12 +618,14 @@ function get_sandbox_module!(meta, prefix, name = nothing; share_default_module
     # Either fetch and return an existing sandbox from the meta dictionary (based on the generated name),
     # or initialize a new clean one, which gets stored in meta for future re-use.
     return get!(meta, sym) do
-        # If the module does not exists already, we need to construct a new one.
-        m = Module(sym)
-        # eval(expr) is available in the REPL (i.e. Main) so we emulate that for the sandbox
-        Core.eval(m, :(eval(x) = Core.eval($m, x)))
-        # modules created with Module() does not have include defined
-        Core.eval(m, :(include(x) = Base.include($m, abspath(x))))
+        # If the module does not exist already, we need to construct a new one.
+        m = Core.eval(Main, :(
+                    module $sym
+                    end
+                )
+            )
+        # Because this was eval'ed in using module creation syntax, `eval`, `include` and `Base`
+        # already exist in the scope of this module.
         return m
     end
 end