Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Temporarily) fix stable docs link in README.md #249

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

jacobusmmsmit
Copy link
Contributor

#246 pointed out that the docs are not correctly deployed. Unfortunately, this is still the case so in the meantime a quick "bandaid" fix which makes the stable docs accessible is just to change the stable docs link.

Right now the stable docs are hard to find unless you know that removing /stable from the url goes there.

Apologies if this is the wrong fix to the problem, it was just bugging me.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c982cde) 81.53% compared to head (0b17192) 81.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files          18       18           
  Lines        1587     1587           
=======================================
  Hits         1294     1294           
  Misses        293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's been bugging me too

@gdalle gdalle merged commit 31016f4 into JuliaDiff:master Apr 14, 2024
5 of 6 checks passed
@devmotion
Copy link
Member

This PR has to be reverted. The new link points to completely outdated docs. IMO a broken link is better than one to incorrect docs.

@gdalle
Copy link
Member

gdalle commented Apr 14, 2024

Okay, but is there a link to the current stable docs? Sorry for merging but I thought this was the right one too, given that it is close to the current URL. So I have in fact used the orange site as a stable docs

@devmotion
Copy link
Member

devmotion commented Apr 14, 2024

It's some docs from years ago. The link was removed on purpose in #246.

@jacobusmmsmit jacobusmmsmit deleted the docs-link branch April 14, 2024 08:43
devmotion added a commit that referenced this pull request Apr 16, 2024
* Revert "Fix stable docs link in README.md (#249)"

This reverts commit 31016f4.

* Update docs configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants