use oneunit, not one, to preserve type in single_seed #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
==========================================
- Coverage 89.65% 86.59% -3.07%
==========================================
Files 11 10 -1
Lines 967 895 -72
==========================================
- Hits 867 775 -92
- Misses 100 120 +20
☔ View full report in Codecov by Sentry. |
|
Bump |
devmotion
approved these changes
May 31, 2025
|
@longemen3000 maybe you can help coming up with a simple test? |
|
maybe using an stripped down version of the |
|
I have some interest in seeing this work completed. Is the proposed test approach acceptable? |
|
It seems reasonable to me. |
|
Not sure how to implement the tests though... @longemen3000 do you have the time to complete this? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #651
This change is also required by #664, so if that PR is accepted then it supersedes this PR.