use oneunit, not one, to preserve type in single_seed#665
use oneunit, not one, to preserve type in single_seed#665stevengj wants to merge 1 commit intoJuliaDiff:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
==========================================
- Coverage 89.65% 86.59% -3.07%
==========================================
Files 11 10 -1
Lines 967 895 -72
==========================================
- Hits 867 775 -92
- Misses 100 120 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bump |
devmotion
left a comment
There was a problem hiding this comment.
Looks good to me. If possible, it would be good to add a test.
|
@longemen3000 maybe you can help coming up with a simple test? |
|
maybe using an stripped down version of the |
|
I have some interest in seeing this work completed. Is the proposed test approach acceptable? |
|
It seems reasonable to me. |
|
Not sure how to implement the tests though... @longemen3000 do you have the time to complete this? 🙏 |
|
i could add another PR with a test, just including a Furlong.jl file (the same as the one used in the julia tests) and then testing: furlong = Furlongs.Furlong{2}(1.0)
f(x) = exp(x) + 4*sin(x)*oneunit(x)
@test ForwardDiff.derivative(f,furlong )= exp(furlong) + 4*cos(furlong)does that seem alright? |
Fixes #651
This change is also required by #664, so if that PR is accepted then it supersedes this PR.