Skip to content

Revert handling of AutoEnzyme(; constant_function) #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jul 31, 2024

Warning

This is a temporary reversion, until @wsmoses can throw an Enzyme error when closures are insufficiently Duplicated. Then we will probably yank a few ADTypes releases and change the default to AutoEnzyme(constant_function=nothing). The goal right now is to make a new release of DI without breaking any code.

DI extensions

DI tests and docs

  • Remove constant_function=true everywhere

@gdalle gdalle changed the title Revert handling of constant_function for Enzyme Revert handling of AutoEnzyme(; constant_function) Jul 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.68%. Comparing base (a65f228) to head (e32a4ad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   96.63%   96.68%   +0.05%     
==========================================
  Files         103      103              
  Lines        4996     4981      -15     
==========================================
- Hits         4828     4816      -12     
+ Misses        168      165       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit fbeaf8e into main Jul 31, 2024
53 checks passed
@gdalle gdalle deleted the gd/noconstf branch July 31, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants