WIP: rrule dot test #208
Open
WIP: rrule dot test #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the code you deleted we still need. |
oxinabox
reviewed
Aug 22, 2021
| @@ -172,7 +172,7 @@ function test_rrule( | |||
| config::RuleConfig, | |||
| f, | |||
| args...; | |||
| output_tangent=Auto(), | |||
| output_cotangent=Auto(), | |||
There was a problem hiding this comment.
So I don't forget if someone does come back to this.
This can't be done.
It is a breaking change.
In general we have decide to use tangent as the word to refer to both tangents and cotangents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please feel free to take charge of this PR if you want to work on this, or to make another one. I can't promise to actively work on it. I just wanted to see what implementing this might look like in practice.