RFC: turn off thunks at 2nd order #568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Aug 5, 2022
| @@ -229,6 +232,8 @@ struct InplaceableThunk{T<:Thunk,F} <: AbstractThunk | |||
| val::T | |||
| end | |||
|
|
|||
| InplaceableThunk(add!, val) = val # if _usethunks() disables @thunk, then bypass this too | |||
oxinabox
reviewed
Aug 5, 2022
| @@ -127,6 +127,9 @@ function LinearAlgebra.LAPACK.trsyl!(transa, transb, A, B, C::AbstractThunk, isg | |||
| return throw(MutateThunkException()) | |||
| end | |||
|
|
|||
| @inline _usethunks() = true | |||
|
Why do we want to do this? |
|
This was part of FluxML/Zygote.jl#1262 (comment), tl;dr is that everything 2nd order in Zygote is broken. Besides problems with the Z-to-CR bridge, the creation of thunks doesn't seem to be differentiable, and ProjectTo also gave problems. But far from sorted out. |
This was referenced Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.