Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reshape(::AbstractZero) #490

Merged
merged 3 commits into from
Oct 12, 2021
Merged

reshape(::AbstractZero) #490

merged 3 commits into from
Oct 12, 2021

Conversation

mcabbott
Copy link
Member

No description provided.

oxinabox
oxinabox approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Fix the thing review dog is complaining about.
(if you PR from a branch of this repo rather than your fork you will be able to apply suggestions BTW)
and bump the version.

@mcabbott
Copy link
Member Author

Should be fixed. I made it 1.8 btw, not really sure what's major/minor for such things.

@mcabbott mcabbott merged commit d0c3599 into JuliaDiff:main Oct 12, 2021
@mcabbott mcabbott deleted the reshape_zero branch October 12, 2021 15:23
@oxinabox
Copy link
Member

1.8 is correct.
this is a new feature.

Almost all PRs should be minor version bumps.
Since patch is for bug fixes, and we hopefully do not have too many bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcabbott @oxinabox