Run integration tests on latest stable julia release #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 14 14
Lines 787 787
=======================================
Hits 731 731
Misses 56 56 Continue to review full report at Codecov.
|
mzgubic
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.5 is old.
Some of our downstream doesn't support it as well.
E.g. ChainRules.jl only promises that things will pass the type inference checks on the latest release.
Which currently our reverse dep test fail because they are testing 1.5 where the ChainRules.jl tests fail at inference.
We could disable those inference tests, but we actually don't want to, since if a ChainRulesCore change breaks inference in ChainRules.jl then we want to know about it.