support constructors with non_differentiable #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
added
needs tests
rule definition helper
oxinabox
force-pushed
the
ox/ndconstruct
branch
from
8ddd9dd to
97b4d89
Compare
|
JuliaDiff/ChainRules.jl#310 (comment) reminded me that i should finish this PR |
mzgubic
approved these changes
Nov 20, 2020
| @test pullback(1.2) == (NO_FIELDS, DoesNotExist()) | ||
|
|
||
| # https://github.com/JuliaDiff/ChainRulesCore.jl/issues/213 | ||
| # problem was that `@nondiff Foo(x)` was also defining rules for other types. |
There was a problem hiding this comment.
Wow, that's funky. I guess solves the issue in this comment?
JuliaDiff/ChainRules.jl#310 (comment)
There was a problem hiding this comment.
Yep.
Its because typeof(Foo) == DataType and typeof(Bar) == DataType
but Core.Typeof(Foo) == Type{Foo} and Core.Typeof(Bar) == Type{Bar}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #213