Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ProjectTo(::NamedTuple) #511

Closed
mzgubic opened this issue Nov 10, 2021 · 2 comments · Fixed by #515
Closed

implement ProjectTo(::NamedTuple) #511

mzgubic opened this issue Nov 10, 2021 · 2 comments · Fixed by #515
Labels
bug Something isn't working ProjectTo related to the projection functionality

Comments

@mzgubic
Copy link
Member

mzgubic commented Nov 10, 2021

Needed in JuliaDiff/ChainRulesTestUtils.jl#224 (see comment)

Simplest possible implementation.
@mzgubic mzgubic added bug Something isn't working ProjectTo related to the projection functionality labels Nov 10, 2021
@devmotion
Copy link
Member

devmotion commented Nov 10, 2021 •
edited
Loading

Can we just add the suggested implementation for now? Or are we aware of any problems?

If not, I could put together a PR later today.

@mzgubic
Copy link
Member Author

mzgubic commented Nov 10, 2021

I am not aware of any but haven't thought about this very deeply.

@devmotion devmotion mentioned this issue Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ProjectTo related to the projection functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ProjectTo(::NamedTuple) JuliaDiff/ChainRulesCore.jl
2 participants
@devmotion @mzgubic