Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is add!!(::Diagonal, ::Array) correct? #345

Open
oxinabox opened this issue May 4, 2021 · 0 comments
Open

Is add!!(::Diagonal, ::Array) correct? #345

oxinabox opened this issue May 4, 2021 · 0 comments
Labels
inplace accumulation for things relating to inplace accumulation of gradients

Comments

@oxinabox
Copy link
Member

oxinabox commented May 4, 2021

Right now we claim that Diagonal is a inplacable_destination if it is wrapping around a vector that is itself an inplacable_destination.
However, Diagonal is only inplacable if the other side is itself diagonal.
Which one might in general assume to be the case since differential types should in general have same structure as primal types.
but IIRC there are some operations that have dense primal, but diagonal differentials.
So if you have that operation and also another function on the same data with a dense differntial then this could happen

@oxinabox oxinabox added the inplace accumulation for things relating to inplace accumulation of gradients label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inplace accumulation for things relating to inplace accumulation of gradients
Projects
None yet
Development

No branches or pull requests

1 participant