Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more non-differentiable builtins #483

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Add more non-differentiable builtins #483

merged 3 commits into from
Jul 29, 2021

Conversation

Keno
Copy link
Contributor

@Keno Keno commented Jul 29, 2021

@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Jul 29, 2021
@Keno Keno mentioned this pull request Jul 29, 2021
Closed
@Keno
Copy link
Contributor Author

Keno commented Jul 29, 2021

If easier this can also be squashed into #463.

@mcabbott
Copy link
Member

Xref #482, which put isdefined under Base not Core, perhaps that line ought to be deleted.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021 •
edited
Loading

Codecov Report

Merging #483 (8350bfe) into master (e6a27db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          21       21           
  Lines        2287     2287           
=======================================
  Hits         2250     2250           
  Misses         37       37
Impacted Files Coverage Δ
src/rulesets/Base/nondiff.jl 66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12f03d...8350bfe. Read the comment docs.

@github-actions github-actions bot removed the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Jul 29, 2021
@mzgubic mzgubic merged commit 3f18cd6 into master Jul 29, 2021
@mzgubic mzgubic deleted the kf/nondiffbuiltins branch July 29, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzgubic mzgubic mzgubic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Keno @mcabbott @codecov-commenter @mzgubic