Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port more array-related derivatives from Nabla #45

Merged
merged 3 commits into from
Jun 6, 2019
Merged

Port more array-related derivatives from Nabla #45

merged 3 commits into from
Jun 6, 2019

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Jun 6, 2019

The stuff in Nabla's src/sensitivities/array.jl, which includes reshape, hcat, vcat, and fill.

oxinabox
oxinabox reviewed Jun 6, 2019
View reviewed changes
src/rules/array.jl Outdated Show resolved Hide resolved
willtebbutt
willtebbutt approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @oxinabox 's comments have been addressed.

@ararslan ararslan merged commit d8baa8f into master Jun 6, 2019
@ararslan ararslan deleted the aa/array-stuff branch June 6, 2019 17:50
@ararslan ararslan mentioned this pull request Jun 18, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtebbutt willtebbutt willtebbutt approved these changes

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ararslan @willtebbutt @oxinabox