Add an rrule for the Cholesky decomposition #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Jun 6, 2019
oxinabox
reviewed
Jun 6, 2019
oxinabox
reviewed
Jun 6, 2019
| d = view(A, j, j) | ||
| B = view(A, j+1:n, 1:j-1) | ||
| c = view(A, j+1:n, j) | ||
| end |
There was a problem hiding this comment.
This mighjt be one of the rare times i suggest wrapping the block in @views
Also didn't we just do out bounds check so we can now @inbounds it.
(again rare time i am going to suggest doing that to a whole l block)
There was a problem hiding this comment.
The only problem with @views is that AFAICT you aren't guaranteed to actually get a view, since it uses Base.maybeview rather than replacing getindex with view.
There was a problem hiding this comment.
Isn't that ok though?
Or does this outright need a view because it is going to mutate it?
There was a problem hiding this comment.
Not sure, I just wanted to make sure this was the same as Nabla's implementation.
oxinabox
reviewed
Jun 6, 2019
oxinabox
reviewed
Jun 6, 2019
This is a direct port of the code from Nabla.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (mostly) direct port of the code from Nabla.