Skip to content

Cancel previous running workflows #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 2, 2021
Merged

Cancel previous running workflows #427

merged 11 commits into from
Jun 2, 2021

Conversation

mzgubic
Copy link
Member

@mzgubic mzgubic commented Jun 1, 2021

I don't know anything about CI, so this might be very wrong - just testing it out

Closes #426

@github-actions github-actions bot added the needs version bump Version needs to be incremented or set to -DEV in Project.toml label Jun 1, 2021
@devmotion
Copy link
Member

I haven't used it anywhere (just opened a PR to KernelFunctions where we had an open issue about canceling workflows) but I think it could be helpful to configuration in https://github.com/styfle/cancel-workflow-action#advanced-pull-requests-from-forks such that it also works for PRs from forks.

@mzgubic
Copy link
Member Author

mzgubic commented Jun 1, 2021

Could we disable email notification when the workflow is cancelled rather than when it fails?

steps:
- uses: styfle/cancel-workflow-action@0.9.0
with:
all_but_latest: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, only the workflows started before this action are cancelled. This flag cancels all but the latest workflow, which is helpful if the pipeline is saturated

@oxinabox
Copy link
Member

oxinabox commented Jun 2, 2021

Hmm this seems to have resulted in everything being cancelled because of VersionVigilante failing.
We don't want everything cancelled when anything fails, since Nightly fails all the time,

@mzgubic
Copy link
Member Author

mzgubic commented Jun 2, 2021

Oh no I cancelled manually because I didn't want to block other pipelines, sorry!

This only runs when merged to master (as per JuliaGaussianProcesses/KernelFunctions.jl#292)

@oxinabox
Copy link
Member

oxinabox commented Jun 2, 2021

OK, lets give this a try

@mzgubic mzgubic merged commit 61b8f12 into master Jun 2, 2021
@mzgubic mzgubic deleted the mz/gha branch June 2, 2021 13:20
@mzgubic
Copy link
Member Author

mzgubic commented Jun 2, 2021

Did not seem to have worked, i.e. this PR still ran two full pipelines:
#433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs version bump Version needs to be incremented or set to -DEV in Project.toml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel running Actions on a new pushed commit
3 participants