Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't thunk if only one adjoint exists #235

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Conversation

sethaxen
Copy link
Member

Following JuliaDiff/ChainRulesTestUtils.jl#53, this PR makes sure pullbacks do not thunk when they only return one non-DoesNotExist adjoint. It adds compatibility for ChainRulesTestUtils v0.5.0.

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye @thunks 👋

LGTM!

@sethaxen sethaxen merged commit 9a364d6 into JuliaDiff:master Jul 13, 2020
@sethaxen sethaxen deleted the nothunk branch July 13, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants