wip: make Cthulhu cache CodeInstance-based
#614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
commented
Nov 21, 2024
aviatesk
force-pushed
the
avi/invoke-codeinstance
branch
from
93dc56d to
7092eed
Compare
Although these code paths don’t seem to be used very often.
aviatesk
force-pushed
the
avi/invoke-codeinstance
branch
from
7092eed to
c1c6407
Compare
aviatesk
changed the title
CodeInstance-based
|
I was able to address what should be the rest of the fixes in a branch at https://github.com/serenity4/Cthulhu.jl/tree/avi/invoke-codeinstance. I guess we can either 1) close this PR and open a new one with my branch, 2) open a PR into this one or 3) I push my changes to your branch and we continue here (requires write permissions). |
|
Friendly ping @aviatesk 🫠 |
|
Sorry for the late reply. I think your commits are definitely better, so let's go with whatever's easiest for you. Would it be simpler to just create a brand new PR? Let me know what works best for you. |
|
Sounds good to me, here it goes: #628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although these code paths don’t seem to be used very often.