Fix ascend, split out find_caller_of and test it #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
ascend
to work with the new internals. This also splits out a bit more of the internals to make them more testable (the UI code is a pain to write tests for).@chriselrod, this should address a wish-list item of yours on discourse: not only does this fix ascend, but I took the opportunity to provide better support for inlining in stacktraces. With this setup:
now when you press enter when the
>
is positioned as above, you get this:The successive indentation shows the sequence of calls that led to
throw_complex_domainerror
and you can select any of them for opening in your editor.