Skip to content

strip_gensym: handle unicode correctly #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timholy merged 1 commit into from
Aug 4, 2024
Merged

strip_gensym: handle unicode correctly #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ function strip_gensym(str::AbstractString)
if startswith(str, '#')
idx = findnext('#', str, 2)
if idx !== nothing
return Symbol(str[2:idx-1])
return Symbol(str[2:prevind(str, idx)])
end
end
endswith(str, "##kw") && return Symbol(str[1:end-4])
endswith(str, "##kw") && return Symbol(str[1:prevind(str, end-3)])
return Symbol(str)
end

Expand Down
5 changes: 5 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,3 +432,8 @@ end
body, _ = CodeTracking.definition(String, which(diffminmax, (Any,)))
@test body == "diffminmax((min, max)) = max - min"
end

@testset "strip_gensym with unicode" begin
@test CodeTracking.strip_gensym("#𝓔′#90") == :𝓔′
@test CodeTracking.strip_gensym("𝓔′##kw") == :𝓔′
end