Resolve warning re use of kwargs.data
#96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Julia v1.8.0-rc4 creating a `DictTable` produces a warning of the form ``` ┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr │ caller = #DictTable#117 at DictTable.jl:31 [inlined] └ @ Core ~/.julia/packages/TypedTables/zfbS2/src/DictTable.jl:31 ```
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 69.63% 69.63%
=======================================
Files 7 7
Lines 909 909
=======================================
Hits 633 633
Misses 276 276
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
I noticed in the testing output that similar changes should be made in lines 27 and 28 of |
quinnj
approved these changes
Aug 16, 2022
|
There is a similar error in FlexTable.jl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Julia v1.8.0-rc4 creating a
DictTableproduces a warning of the form