Fix a type instability in a few error paths that result in the parsed… #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igits return type being unstable when an apply function is passed. Made a new helper with a detailed comment explaining the type instability + rules to follow to hopefully avoid these issues in the future.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 10 10
Lines 1890 1891 +1
=======================================
+ Hits 1671 1672 +1
Misses 219 219 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…igits
return type being unstable when an apply function is passed. Made a new helper with a detailed comment explaining the type instability + rules to follow to hopefully avoid these issues in the future.