Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce INEXACT code and use it for DateTime #172

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Introduce INEXACT code and use it for DateTime #172

merged 3 commits into from
Jun 6, 2023

Conversation

Drvi
Copy link
Collaborator

@Drvi Drvi commented Jun 6, 2023

Followup from #171

@Drvi Drvi requested a review from quinnj June 6, 2023 09:09
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 86.36% and project coverage change: -0.10 ⚠️

Comparison is base (4d4efcc) 88.49% compared to head (f118cb5) 88.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   88.49%   88.39%   -0.10%     
==========================================
  Files          10       10              
  Lines        1852     1862      +10     
==========================================
+ Hits         1639     1646       +7     
- Misses        213      216       +3     
Impacted Files Coverage Δ
src/utils.jl 83.93% <33.33%> (-0.51%) ⬇️
src/dates.jl 76.38% <91.66%> (+0.20%) ⬆️
src/components.jl 98.75% <100.00%> (ø)
src/floats.jl 89.03% <100.00%> (ø)
src/ints.jl 91.39% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quinnj quinnj merged commit 3e4d628 into main Jun 6, 2023
@quinnj quinnj deleted the td-inexact branch June 6, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants