Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always strip quoted ' ' and '\t' when stripquoted=true #116

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

nickrobinson251
Copy link
Collaborator

@nickrobinson251 nickrobinson251 commented Apr 22, 2022

  • closes stripquoted doesn't know to strip quoted whitespace when space is the delimiter #115 (see issue for details)
  • ...but i'm not sure if hardcoding ' ' and '\t' as whitespace (when in quotes) is a great idea
    • we do hardcode '\n' and '\r' as newline chars, which seems fairly analogous
    • but we do expose wh1 and wh2 for whitespace
  • an alternative is to expose qwh1, qwh2 keywords for setting "chars to be considered leading/trailing whitespace in quoted strings", but it'd only be used in this one use-case, so i'm inclined to think we can wait til it's requested

@quinnj
Copy link
Member

quinnj commented Apr 26, 2022

Ok, spent a little time noodling on this and I think I'm coming to the same conclusion: hard code for now, maybe have qwh1/qwh2 in the future. Let me noodle on it just a bit more, but I think this is probably good.

@nickrobinson251 nickrobinson251 changed the title Always strip quoted ' ' and '\t' when stripquoted=true Always strip quoted ' ' and '\t' when stripquoted=true Apr 26, 2022
@quinnj quinnj merged commit 6edcaab into JuliaData:main Apr 27, 2022
@nickrobinson251 nickrobinson251 deleted the npr/115-quoted-whitespace branch April 27, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stripquoted doesn't know to strip quoted whitespace when space is the delimiter
2 participants